Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize runbooks and add wiki replace runbook #312

Merged
merged 11 commits into from
Oct 18, 2024

Conversation

magdalendobson
Copy link
Collaborator

@magdalendobson magdalendobson commented Oct 10, 2024

This PR makes three contributions:

  1. Since the number of runbooks and generating files is getting larger, moved them to their own folder inside neurips23.
  2. Replaced the two generators for the existing MSMarco and Wiki-Cohere runbooks with one generic function (runbooks/gen_expiration_time_runbook.py).
  3. Uses that same generic function to add five additional expiration time based runbooks for Wiki-Cohere, which use a mix of delete and replace.

@harsha-simhadri
Copy link
Owner

Does this file location move break existing scripts and README?

@magdalendobson
Copy link
Collaborator Author

I updated the neurips23 README so all commands there should work as expected. I also updated data_export.py, which depends on runbook paths. Do you think this is too disruptive a change for people who have scripts they run offline?

@harsha-simhadri
Copy link
Owner

harsha-simhadri commented Oct 11, 2024

Could you please publish this draft PR. Also, lets plan to upload Gt for the new runbooks.

@harsha-simhadri
Copy link
Owner

Q:\big-ann-benchmarks> python benchmark/streaming/compute_gt.py --dataset wikipedia-35M --runbook neurips23/streaming/runbooks/wikipedia-35M_expiration_time_replace_runbook.yaml --gt_cmdline_tool c:\Users\harshasi\source\DiskANN\x64\Release\compute_groundtruth.exe
Traceback (most recent call last):
File "Q:\big-ann-benchmarks\benchmark\streaming\compute_gt.py", line 149, in
main()
File "Q:\big-ann-benchmarks\benchmark\streaming\compute_gt.py", line 111, in main
max_pts, runbook = load_runbook(args.dataset, ds.nb, args.runbook_file)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "Q:\big-ann-benchmarks\benchmark\streaming\load_runbook.py", line 33, in load_runbook
raise Exception('End of indices to be replaced out of range in runbook')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Exception: End of indices to be replaced out of range in runbook

@magdalendobson magdalendobson marked this pull request as ready for review October 18, 2024 19:03
@harsha-simhadri harsha-simhadri merged commit 3c35f54 into main Oct 18, 2024
48 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants